Skip to content

smoke_render: run the goldens on PRs #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdero merged 1 commit into from
May 25, 2026
+13 −3
Merged

smoke_render: run the goldens on PRs #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions .github/workflows/smoke_render.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,22 @@ name: smoke render
# Renders a small set of deterministic scenes against the latest Flutter master
# and uploads the frames to Argos for visual diffing. Catches rendering
# regressions (black screen / nothing drawn / unlit) that crash tests miss.
# Manual or daily. Notifies Discord on failure.
# Runs on pull requests and pushes to master, so Argos diffs each PR against
# the master baseline, plus manually and daily. Notifies Discord when a
# non-PR run fails.

on:
workflow_dispatch:
schedule:
- cron: "0 7 * * *" # daily, 07:00 UTC
push:
branches: [master]
pull_request:

# A new push to a branch or PR supersedes its still-running render.
concurrency:
group: smoke-render-${{ github.ref }}
cancel-in-progress: true

jobs:
linux:
Expand Down Expand Up @@ -55,7 +65,7 @@ jobs:
url=$(printf '%s' "$out" | grep -oE 'https://app\.argos-ci\.com/[^[:space:]]+' | head -1)
echo "build_url=$url" >> "$GITHUB_OUTPUT"
- name: Notify Discord on failure
if: failure()
if: failure() && github.event_name != 'pull_request'
env:
DISCORD_WEBHOOK_URL: ${{ secrets.DISCORD_WEBHOOK_URL }}
ARGOS_URL: ${{ steps.argos.outputs.build_url }}
Expand Down Expand Up @@ -101,7 +111,7 @@ jobs:
url=$(printf '%s' "$out" | grep -oE 'https://app\.argos-ci\.com/[^[:space:]]+' | head -1)
echo "build_url=$url" >> "$GITHUB_OUTPUT"
- name: Notify Discord on failure
if: failure()
if: failure() && github.event_name != 'pull_request'
env:
DISCORD_WEBHOOK_URL: ${{ secrets.DISCORD_WEBHOOK_URL }}
ARGOS_URL: ${{ steps.argos.outputs.build_url }}
Expand Down
Loading