Skip to content

Conversation

@beNative
Copy link
Owner

Summary

  • add nested submenu rendering support to the shared context menu component
  • introduce a Table submenu in the rich text editor context menu with table selection and edit actions

Testing

  • npm test

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +172 to +176
key={`${label}-${depth}-${index}`}
className="relative"
onMouseEnter={() => setActiveSubmenu({ depth, index })}
onMouseLeave={() => setActiveSubmenu(prev => (prev?.depth === depth && prev.index === index ? null : prev))}
>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Submenus collapse when hovering child items

Hovering into a nested menu immediately removes the submenu, making its actions impossible to click. Each list item overwrites activeSubmenu with its own {depth, index} on hover (shown here) while submenu rendering later is gated by isSubmenuActive matching the parent’s depth; as soon as the pointer enters a child item the parent no longer matches and its submenu unmounts, so the new Table submenu in the rich text context menu disappears before any child action can be selected.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants