fix: add request registration for early failures in device instructio…#812
Open
wakonig wants to merge 1 commit into
Open
fix: add request registration for early failures in device instructio…#812wakonig wants to merge 1 commit into
wakonig wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures device-instruction requests are registered even when failures occur early in handle_device_instructions, so the system can still emit a deterministic “running → error” resolution sequence.
Changes:
- Add
_ensure_request_registered()to register a placeholder request for early-failure paths. - Call
_ensure_request_registered()in exception handlers beforeset_finished()to guarantee resolution. - Update the disabled-device test to assert actual outbound response messages via
connector.send.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
bec_server/bec_server/device_server/device_server.py |
Adds placeholder request registration and invokes it in exception handling to allow early failures to resolve. |
bec_server/tests/tests_device_server/test_device_server.py |
Updates test expectations to validate the emitted response message sequence for early failures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9b16ff6 to
47c2a5a
Compare
d-perl
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ns handling