Show path separator error regardless of directory existence#1
Open
bejaratommy wants to merge 1 commit intomasterfrom
Open
Show path separator error regardless of directory existence#1bejaratommy wants to merge 1 commit intomasterfrom
bejaratommy wants to merge 1 commit intomasterfrom
Conversation
Previously, `fd` only warned about patterns containing path separators when the pattern also happened to be an existing directory. This was inconsistent: patterns with path separators will never match any filenames (since filenames cannot contain path separators), so the warning is helpful regardless. Now the error is always shown when a pattern contains a path separator and `--full-path` is not set. When the pattern is an existing directory, the suggestion to search inside it is still included. Fixes sharkdp#1873
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously,
fdonly warned about patterns containing path separators when the pattern also happened to be an existing directory. This led to inconsistent behavior:fd /→ error (because/is a directory)fd nonexistent/path→ silent, no resultsSince filenames cannot contain path separators, a pattern with a path separator (without
--full-path) will never match anything, so the warning should always be shown.Changes
Path::new(pattern).is_dir()guard from the path separator checkfd . 'dir')--full-path--full-pathbypassFixes sharkdp#1873