fix: copy eval requirements.txt into Docker build context#245
Open
JasonOA888 wants to merge 1 commit intobenchflow-ai:mainfrom
Open
fix: copy eval requirements.txt into Docker build context#245JasonOA888 wants to merge 1 commit intobenchflow-ai:mainfrom
JasonOA888 wants to merge 1 commit intobenchflow-ai:mainfrom
Conversation
_default_dockerfile generates 'COPY requirements.txt /tmp/requirements.txt' but the file lives at skill_dir/evals/requirements.txt, which is outside the Docker build context (task_dir/environment/). The evals/ directory is also explicitly excluded from the skills copytree. This causes Docker build to fail with 'requirements.txt not found' when a skill eval specifies custom Python dependencies. Fix: copy evals/requirements.txt into the environment directory during task generation so the Dockerfile COPY can find it.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_default_dockerfile generates
COPY requirements.txt /tmp/requirements.txtwhen a skill hasevals/requirements.txt. However, this file lives atskill_dir/evals/requirements.txt, which is outside the Docker build context (task_dir/environment/). Theevals/directory is also explicitly excluded from the skillscopytreeviashutil.ignore_patterns("evals", ...).This causes
docker buildto fail with:Fix: copy
evals/requirements.txtinto the environment directory during task generation so the Dockerfile COPY can find it.