fix(header,footer): remove fragment loading antipattern#22
Merged
Conversation
Header and footer loaded fragments from CMS pages that don't exist, causing 404 requests on live and a crash in the footer (no null guard). The content is static — inline it directly and delete the stub files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ben Peter <bp@ben-peter.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ben Peter <bp@ben-peter.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadFragment()/getMetadata()calls from header and footer blocks — they fetched CMS pages (/nav,/footer) that don't exist, causing 404 requests on live and a footer crash (no null guard)nav.plain.htmlandfooter.plain.htmlstub files and the*.plain.htmlhlxignore rule they requiredTest plan
© 2026 Ben Peter · Legal Notice · Privacy Policy/nav.plain.htmlor/footer.plain.htmlin network tabnpm run lintpassesTest URLs:
🤖 Generated with Claude Code