fix(test): fix rpcErrorProxy race causing flaky ConnectionDrop recovery test#3117
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a race in the test proxy's intercept() where active and dropConn atomics were loaded separately, allowing a concurrent deactivate() to clear them between loads and cause a spurious empty JSON-RPC error response instead of a connection drop — making TestFinalizeBlock_ConnectionDrop_Recovery flaky.
Changes:
- Snapshot
activeanddropConnonce at entry tointercept(). - Use the snapshotted
dropConnvalue for the subsequent branch decision.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a flaky
TestFinalizeBlock_ConnectionDrop_Recoverytest by snapshottingactive/dropConnonce inintercept()instead of reading them separately.deactivate()clears the two flags in separate stores, so a request could race in and serve a spurious empty JSON-RPC error instead of dropping the connection. The CL treats that error as non-retryable, soFinalizeBlockfails instead of recovering.