Open
Conversation
|
Nice feature! Personally, I would like to have this configurable in settings (or via some button next to input), so we keep backward compatibility. Also, personally, sometimes I still find it useful to have diff visible – I often use native browser search to find some info in diffs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is quite simplistic and just uses
style='none', happy to use a CSS class instead. It does mean that it would remove any other content that existed instyle, but as it stands the element doesn't have any styles applied to it. Some of the nested divs do usestyle- e.g. the header of the diff file usesstyle="top: 60px !important; position: sticky;"I was thinking with CSS classes they may be more likely to be overridden by Github code causing the diffs to reappear.
I can add an option to disable this feature if you want, let me know
Demo
