Skip to content

Reuse cursor(sample) for all agents per trial#2

Open
sroecker wants to merge 1 commit intobgalbraith:masterfrom
sroecker:reuse_cursor
Open

Reuse cursor(sample) for all agents per trial#2
sroecker wants to merge 1 commit intobgalbraith:masterfrom
sroecker:reuse_cursor

Conversation

@sroecker
Copy link
Copy Markdown

Since there is no need to use a different precalculated sample for each agent the cursor can be updated in the environment after each trial.

@bgalbraith
Copy link
Copy Markdown
Owner

Hi @sroecker. I think what you're addressing is the fact that when we do choose to pre-cache random samples in the bandit, we should draw from the same iteration sample pool for every agent instead of each agent getting a unique set of samples per iteration. That's a valid point, though introducing coupling between the environment and the bandit, especially to an ostensibly private property, isn't the best solution.

Thanks for the input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants