Skip to content

feat(): SMX-242 - migrate to ESLint 9 flat config #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielochoa-epam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(): SMX-242 - migrate to ESLint 9 flat config #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 0 additions & 63 deletions .eslintrc.json
View file
Open in desktop

This file was deleted.

26 changes: 13 additions & 13 deletions components/error.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,22 @@ import { H3, Panel } from '@bigcommerce/big-design';
import { ErrorMessageProps, ErrorProps } from '../types';

const ErrorContent = ({ message }: Pick<ErrorProps, 'message'>) => (
<>
<H3>Failed to load</H3>
{message}
</>
)
<>
<H3>Failed to load</H3>
{message}
</>
);

const ErrorMessage = ({ error, renderPanel = true }: ErrorMessageProps) => {
if (renderPanel) {
return (
<Panel>
<ErrorContent message={error.message} />
</Panel>
)
}
if (renderPanel) {
return (
<Panel>
<ErrorContent message={error.message} />
</Panel>
);
}

return <ErrorContent message={error.message} />
return <ErrorContent message={error.message} />;
};

export default ErrorMessage;
215 changes: 110 additions & 105 deletions components/form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,126 +1,131 @@
import { Button, Checkbox, Flex, FormGroup, Input, Panel, Select, Form as StyledForm, Textarea } from '@bigcommerce/big-design';
import {
Button,
Checkbox,
Flex,
FormGroup,
Input,
Panel,
Select,
Form as StyledForm,
Textarea,
} from '@bigcommerce/big-design';
import { ChangeEvent, FormEvent, useState } from 'react';
import { FormData, StringKeyValue } from '../types';

interface FormProps {
formData: FormData;
onCancel(): void;
onSubmit(form: FormData): void;
formData: FormData;
onCancel(): void;
onSubmit(form: FormData): void;
}

const FormErrors = {
name: 'Product name is required',
price: 'Default price is required',
name: 'Product name is required',
price: 'Default price is required',
};

const Form = ({ formData, onCancel, onSubmit }: FormProps) => {
const { description, isVisible, name, price, type } = formData;
const [form, setForm] = useState<FormData>({ description, isVisible, name, price, type });
const [errors, setErrors] = useState<StringKeyValue>({});
const { description, isVisible, name, price, type } = formData;
const [form, setForm] = useState<FormData>({ description, isVisible, name, price, type });
const [errors, setErrors] = useState<StringKeyValue>({});

const handleChange = (event: ChangeEvent<HTMLInputElement | HTMLTextAreaElement>) => {
const { name: formName, value } = event.target || {};
setForm(prevForm => ({ ...prevForm, [formName]: value }));
const handleChange = (event: ChangeEvent<HTMLInputElement | HTMLTextAreaElement>) => {
const { name: formName, value } = event.target || {};
setForm((prevForm) => ({ ...prevForm, [formName]: value }));

// Add error if it exists in FormErrors and the input is empty, otherwise remove from errors
!value && FormErrors[formName]
? setErrors(prevErrors => ({ ...prevErrors, [formName]: FormErrors[formName] }))
: setErrors(({ [formName]: removed, ...prevErrors }) => ({ ...prevErrors }));
};
// Add error if it exists in FormErrors and the input is empty, otherwise remove from errors
!value && FormErrors[formName]
? setErrors((prevErrors) => ({ ...prevErrors, [formName]: FormErrors[formName] }))
: setErrors(({ [formName]: removed, ...prevErrors }) => ({ ...prevErrors }));
};

const handleSelectChange = (value: string) => {
setForm(prevForm => ({ ...prevForm, type: value }));
};
const handleSelectChange = (value: string) => {
setForm((prevForm) => ({ ...prevForm, type: value }));
};

const handleCheckboxChange = (event: ChangeEvent<HTMLInputElement>) => {
const { checked, name: formName } = event.target || {};
setForm(prevForm => ({ ...prevForm, [formName]: checked }));
};
const handleCheckboxChange = (event: ChangeEvent<HTMLInputElement>) => {
const { checked, name: formName } = event.target || {};
setForm((prevForm) => ({ ...prevForm, [formName]: checked }));
};

const handleSubmit = (event: FormEvent<EventTarget>) => {
event.preventDefault();
const handleSubmit = (event: FormEvent<EventTarget>) => {
event.preventDefault();

// If there are errors, do not submit the form
const hasErrors = Object.keys(errors).length > 0;
if (hasErrors) return;
// If there are errors, do not submit the form
const hasErrors = Object.keys(errors).length > 0;
if (hasErrors) return;

onSubmit(form);
};
onSubmit(form);
};

return (
<StyledForm onSubmit={handleSubmit}>
<Panel header="Basic Information">
<FormGroup>
<Input
error={errors?.name}
label="Product name"
name="name"
required
value={form.name}
onChange={handleChange}
/>
</FormGroup>
<FormGroup>
<Select
label="Product type"
name="type"
options={[
{ value: 'physical', content: 'Physical' },
{ value: 'digital', content: 'Digital' }
]}
required
value={form.type}
onOptionChange={handleSelectChange}
/>
</FormGroup>
<FormGroup>
<Input
error={errors?.price}
iconLeft={'$'}
label="Default price (excluding tax)"
name="price"
placeholder="10.00"
required
type="number"
step="0.01"
value={form.price}
onChange={handleChange}
/>
</FormGroup>
<FormGroup>
<Checkbox
name="isVisible"
checked={form.isVisible}
onChange={handleCheckboxChange}
label="Visible on storefront"
/>
</FormGroup>
</Panel>
<Panel header="Description">
<FormGroup>
{/* Using description for demo purposes. Consider using a wysiwig instead (e.g. TinyMCE) */}
<Textarea
label="Description"
name="description"
placeholder="Product info"
value={form.description}
onChange={handleChange}
/>
</FormGroup>
</Panel>
<Flex justifyContent="flex-end">
<Button
marginRight="medium"
type="button"
variant="subtle"
onClick={onCancel}
>
Cancel
</Button>
<Button type="submit">Save</Button>
</Flex>
</StyledForm>
);
return (
<StyledForm onSubmit={handleSubmit}>
<Panel header="Basic Information">
<FormGroup>
<Input
error={errors?.name}
label="Product name"
name="name"
required
value={form.name}
onChange={handleChange}
/>
</FormGroup>
<FormGroup>
<Select
label="Product type"
name="type"
options={[
{ value: 'physical', content: 'Physical' },
{ value: 'digital', content: 'Digital' },
]}
required
value={form.type}
onOptionChange={handleSelectChange}
/>
</FormGroup>
<FormGroup>
<Input
error={errors?.price}
iconLeft={'$'}
label="Default price (excluding tax)"
name="price"
placeholder="10.00"
required
type="number"
step="0.01"
value={form.price}
onChange={handleChange}
/>
</FormGroup>
<FormGroup>
<Checkbox
name="isVisible"
checked={form.isVisible}
onChange={handleCheckboxChange}
label="Visible on storefront"
/>
</FormGroup>
</Panel>
<Panel header="Description">
<FormGroup>
{/* Using description for demo purposes. Consider using a wysiwig instead (e.g. TinyMCE) */}
<Textarea
label="Description"
name="description"
placeholder="Product info"
value={form.description}
onChange={handleChange}
/>
</FormGroup>
</Panel>
<Flex justifyContent="flex-end">
<Button marginRight="medium" type="button" variant="subtle" onClick={onCancel}>
Cancel
</Button>
<Button type="submit">Save</Button>
</Flex>
</StyledForm>
);
};

export default Form;
Loading
Loading