Load Rules lazyly#70
Open
melicerte wants to merge 4 commits into
Open
Conversation
Author
|
@Nek- What do you think about merging this PR ? |
Contributor
|
First we need to fix that: #73 |
Nek-
suggested changes
Mar 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use proxy manager to proxify Rules.
Rules should not be loaded with all dependent services at each start of the application.
Who knows how many services are injected by Rules ?
Instead, set each Rule as a lazy service.
BUT, the downside is that I put
onandafterfunctions asstaticto be able to get events without initialize the Rule object.So it comes with less flexibility, as you cannot define complex behaviour in
onandafterfunctions.Oh, and it breaks compatibility, obviously.
Another (better ?) idea would be to split detection and execution in 2 classes.
One
Rulewithonor/andafterfunction and onHandlerwith one functionhandlewhich will execute what needs to be executed.And only the Handler would be set as lazy.
BUT, the downside is that one would have to implement two classes instead of one ...