Skip to content

[codex] Tighten host tree topbar UX#1411

Merged
binaricat merged 1 commit into
mainfrom
codex/hosttree-topbar-ux
Jun 11, 2026
Merged

[codex] Tighten host tree topbar UX#1411
binaricat merged 1 commit into
mainfrom
codex/hosttree-topbar-ux

Conversation

@binaricat

Copy link
Copy Markdown
Owner

Summary

  • Add separate Custom CSS hooks for the host-list toggle and quick-switcher plus button in the top tab bar.
  • Stop automatically reopening the host tree sidebar when returning to terminal/editor work tabs.
  • Align the Vault surface to the top tab bar by removing the extra top padding.

Validation

  • node --test --import tsx application/app/AppHostTreeLayer.test.ts components/TopTabs.test.ts components/VaultViewLayout.test.ts
  • npm run lint
  • npm run build
  • npm test passed before the final quick-switcher hook addition; the focused tests, lint, and build were rerun after that change.
  • Opened http://127.0.0.1:5173/ in the in-app browser and verified the Vault surface starts immediately below the top tab bar. Terminal creation cannot be fully exercised in browser-only Vite mode because the Electron terminal backend is unavailable there.

@binaricat binaricat marked this pull request as ready for review June 11, 2026 09:49
@binaricat binaricat merged commit 3b52530 into main Jun 11, 2026
18 checks passed
@binaricat binaricat deleted the codex/hosttree-topbar-ux branch June 11, 2026 09:49

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ca16b91ddc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread components/TopTabs.tsx
<Button
variant="ghost"
size="icon"
data-section="top-tabs-quick-switcher-toggle"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Cover the overflow quick switcher toggle

When the tab strip overflows, the !hasOverflow plus button is not rendered and the quick switcher is instead opened by the overflow MoreHorizontal button below, which does not have this data-section. As a result, custom CSS using the newly documented [data-section="top-tabs-quick-switcher-toggle"] hook only hides/styles the quick-switcher control until enough tabs are open, at which point the same control reappears as the overflow button. Add the same hook to the overflow quick-switcher button or a shared wrapper.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant