[codex] Tighten host tree topbar UX#1411
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca16b91ddc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <Button | ||
| variant="ghost" | ||
| size="icon" | ||
| data-section="top-tabs-quick-switcher-toggle" |
There was a problem hiding this comment.
Cover the overflow quick switcher toggle
When the tab strip overflows, the !hasOverflow plus button is not rendered and the quick switcher is instead opened by the overflow MoreHorizontal button below, which does not have this data-section. As a result, custom CSS using the newly documented [data-section="top-tabs-quick-switcher-toggle"] hook only hides/styles the quick-switcher control until enough tabs are open, at which point the same control reappears as the overflow button. Add the same hook to the overflow quick-switcher button or a shared wrapper.
Useful? React with 👍 / 👎.
Summary
Validation
node --test --import tsx application/app/AppHostTreeLayer.test.ts components/TopTabs.test.ts components/VaultViewLayout.test.tsnpm run lintnpm run buildnpm testpassed before the final quick-switcher hook addition; the focused tests, lint, and build were rerun after that change.http://127.0.0.1:5173/in the in-app browser and verified the Vault surface starts immediately below the top tab bar. Terminal creation cannot be fully exercised in browser-only Vite mode because the Electron terminal backend is unavailable there.