Conversation
|
current issue: try -E fails when the dir is in /tmp specifically: temp curr resolution: setting mktemp to use another dir |
Closes #185. Try was making way too many tempfiles. Now we store everything in the sandbox, with a tiny bit of nuance: $IGNORE_FILE needs to be created in advance to handle the args properly. So we create that temporary unconditionally. When running a command (the try() function), we'll move $IGNORE_FILE into the sandbox. When running try commit or try summary, we just delete $IGNORE_FILE at the end.
| fi | ||
| LOWER_DIRS="$OPTARG" | ||
| NO_COMMIT="quiet";; | ||
| (E) if [ -n "$EXCL_ENTS" ] |
There was a problem hiding this comment.
Why not allow this to work like -i, where you can specify multiple ignores on the command-line?
There was a problem hiding this comment.
we can, they are just comma separated, which is easier to impl than allowing for -i to be called multiple times imo
There was a problem hiding this comment.
Easier to implement doesn't carry much weight for me. It makes sense to use overlay's colon-separated stuff for lowerdirs, but the find and grep interfaces seem biased in favor of multiple invocations. Multiple flags also makes it easier to generate invocations---you don't have to group all of your ignores in one place.
What is the actual command that causes this failure?
Is this a 'resolution' or a workaround? Seems like a workaround. If the failure is just when |
example:
./try -E STYLE.md -n "ls"TODO