[pull] develop from smartcontractkit:develop#261
Merged
pull[bot] merged 6 commits intobit-cook:developfrom Mar 26, 2026
Merged
Conversation
* deployment: use timelock qualifier in SetConfigMCMSV2 changeset The SetConfigMCMSV2 changeset was loading MCMS with timelock state using MaybeLoadMCMSWithTimelockState, which does not support timelock qualifiers. This meant that when a ProposalConfig specified a TimelockQualifierPerChain, the qualifier was silently ignored during both validation and execution, causing the changeset to load the wrong timelock state. Update both Validate() and SetConfigMCMSV2() to extract the qualifier from ProposalConfig.TimelockQualifierPerChain and pass it to the new MaybeLoadMCMSWithTimelockStateWithQualifier function. When ProposalConfig is nil, the qualifier defaults to an empty string, preserving backward compatibility. * deployment: add unit tests for timelock qualifier in SetConfigMCMSV2 Add TestSetConfigMCMSV2WithTimelockQualifier to verify that the TimelockQualifierPerChain field in ProposalConfig is correctly extracted and passed to MaybeLoadMCMSWithTimelockStateWithQualifier during validation. The test deploys two MCMS instances on the same chain with different qualifiers (CLLCCIP and RMNMCMS), mirroring the production setup, and validates four scenarios: - CLLCCIP qualifier resolves to the correct MCMS deployment - RMNMCMS qualifier resolves to the correct MCMS deployment - Empty qualifier fails with "found more than one instance" when multiple MCMS deployments exist, documenting the problem this changeset solves - Non-existent qualifier fails with "no addresses found"
* use sampling logger for CRE soak test * throw more HDD at the runner, save fake data provider logs to a file * add debug to runs-on, use more powerful runner * redirect Gin output to log file * do not close the log file on test clean up as gin writes to it after the clean up
* remove all unused integration-tests code * clean up go.mod and go.md * Fix go.md
* Update PostValidation script * Lint fixes * Updates perf fix & v2 FQ * fixes * refactor * Fixes * Lint fixes & others * run go modtidy * refactor * Addressed comments & fixes * formatting * Add GasPriceStalenessThreshold back * FQ test fixes
* add CRE upgrade pipeline * bump CTF * pass some buildcmd * save Docker logs * clean up + uncomment df1 compat tests * exclude rc and beta refs from upgrade tests * support passing custom refs * add upgrade tests to build publish pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )