Skip to content

Guard snapshot process signals in GUI#2457

Open
Ajeem-git wants to merge 2 commits intobit-team:devfrom
Ajeem-git:issue-1604-process-lookup-guard
Open

Guard snapshot process signals in GUI#2457
Ajeem-git wants to merge 2 commits intobit-team:devfrom
Ajeem-git:issue-1604-process-lookup-guard

Conversation

@Ajeem-git
Copy link
Copy Markdown

Summary:
Prevent a GUI crash when pause, resume, or stop is clicked after the snapshot process has already disappeared on a slow system.

What changed:

  • route snapshot SIGSTOP / SIGCONT / SIGKILL through a guarded helper
  • refresh backup state if the snapshot PID is already gone instead of crashing with ProcessLookupError
  • keep the stop action behavior the same when the process is still alive

Testing:

  • python3.11 -m py_compile qt/app.py

Closes #1604

@buhtz buhtz added the PR: Waiting for review PR won't be merged until review and approval from a member of the maintenance team. label Mar 30, 2026
@buhtz
Copy link
Copy Markdown
Member

buhtz commented Mar 30, 2026

Hello Ajeem,

thank you for your contribution and taking time to improve Back In Time. I appreciate it.

On a quick initial review your PR looks good. I'll review it in detail later.

Please note that currently I have to put all PRs on hold, because the Back In Time code base is in a transition phase. I am rewriting the mounting subsystem from scratch (PR #2449). Since the components are not well isolated, this affects nearly every file. To avoid complex merge conflicts, all other PRs are temporarily on hold.

Best wishes,
Christian

@buhtz buhtz added this to the Upcoming next (2.0.0) milestone Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Waiting for review PR won't be merged until review and approval from a member of the maintenance team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ProcessLookupError with rare combination of start/stop/pause buttons on a slow system

2 participants