Skip to content

Conversation

Copy link

Copilot AI commented Nov 16, 2025

Corrected systemd-networkd configuration file paths that were incorrectly documented as residing in /usr/lib/systemd/system/ instead of the correct /usr/lib/systemd/network/ directory.

Changes

  • Updated paths for all .network configuration files in STACK.md:
    • 10-tenant-bridge.network
    • 20-wg-tenant.network
    • 30-vxlan-tenant.network
    • 40-vlan-tenant.network

Before:

#### 📄 /usr/lib/systemd/system/40-vlan-tenant.network:

After:

#### 📄 /usr/lib/systemd/network/40-vlan-tenant.network:

Addresses feedback from #7.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: danielbodnar <1790726+danielbodnar@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback from PR #7 on changes Fix systemd-networkd configuration file paths in documentation Nov 16, 2025
Copilot AI requested a review from danielbodnar November 16, 2025 22:18
@danielbodnar danielbodnar marked this pull request as ready for review January 11, 2026 23:30
Copilot AI review requested due to automatic review settings January 11, 2026 23:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects systemd-networkd configuration file paths in the STACK.md documentation. The changes address an issue where .network configuration files were incorrectly documented as residing in /usr/lib/systemd/system/ instead of the correct /usr/lib/systemd/network/ directory. However, the fix is incomplete as it only addresses .network files while leaving .netdev files with the same incorrect path.

Changes:

  • Updated four .network file paths from /usr/lib/systemd/system/ to /usr/lib/systemd/network/
  • Corrected paths for: 10-tenant-bridge.network, 20-wg-tenant.network, 30-vxlan-tenant.network, and 40-vlan-tenant.network

```

#### 📄 /usr/lib/systemd/system/10-tenant-bridge.network:
#### 📄 /usr/lib/systemd/network/10-tenant-bridge.network:
Copy link

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this .network file path has been correctly fixed, there are three .netdev files in this document (lines 312, 344, and 372) that still have the incorrect path /usr/lib/systemd/system/ instead of /usr/lib/systemd/network/. Both .netdev and .network files are systemd-networkd configuration files and should reside in the same /usr/lib/systemd/network/ directory, not in /usr/lib/systemd/system/ which is for systemd service unit files.

Copilot uses AI. Check for mistakes.
@danielbodnar
Copy link
Contributor

@copilot please run a new git diff against the main branch and resummarize the changes after the last merge in main, to verify all these changes have been merged into main and the suggestions here implement and this PR can be cancelled and the branch deleted.

Copy link
Author

Copilot AI commented Jan 11, 2026

@copilot please run a new git diff against the main branch and resummarize the changes after the last merge in main, to verify all these changes have been merged into main and the suggestions here i...

After reviewing the PR history, this PR can be closed. PR #11 ("Consolidate all PR changes into single branch") was merged into main on 2026-01-11 and includes a more comprehensive fix:

All changes from this branch have been superseded by the consolidated PR #11.

@danielbodnar danielbodnar deleted the copilot/sub-pr-7 branch January 14, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants