docs(wallet): remove outdated xpub-only multipath restriction#513
Open
ANAMASGARD wants to merge 1 commit into
Open
docs(wallet): remove outdated xpub-only multipath restriction#513ANAMASGARD wants to merge 1 commit into
ANAMASGARD wants to merge 1 commit into
Conversation
Update two-path descriptor docs to reflect that both public and private extended keys are supported. Add an ignored test for private multipath wallet creation to enable when miniscript 13.1.0 ships with 4.0. Closes bitcoindevkit#511
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #511
Summary
create_from_two_path_descriptor,CreateParams::new_two_path, andLoadParams::two_path_descriptor#[ignore]test documenting expected private multipath behavior once miniscript 13.1.0 / bdk_chain 0.24.0 land in 4.0Test plan
cargo test test_create_two_path_wallet(2 passed, 1 ignored)cargo test --doccargo check --all-features --all-targetsNotes
Docs are preparatory for 4.0. The ignored test should be enabled when maintainers bump to miniscript 13.1.0+.
Related: #306, #418, #506, #510