Skip to content

Conversation

@david-livefront
Copy link
Collaborator

🎟️ Tracking

N/A

📔 Objective

A minor update to simplify parts of the build scripts and improve performance in builds.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@david-livefront david-livefront requested a review from a team as a code owner January 28, 2026 20:49
@david-livefront david-livefront added t:misc Change Type - ¯\_(ツ)_/¯ ai-review Request a Claude code review labels Jan 28, 2026
@github-actions github-actions bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:feature-tool Change Type - Internal tool feature or enhancement and removed t:misc Change Type - ¯\_(ツ)_/¯ labels Jan 28, 2026
@claude
Copy link
Contributor

claude bot commented Jan 28, 2026

Claude finished @david-livefront's task in 2m 2s —— View job


Code Review Summary

Status: Approved

Overview

This PR consolidates duplicate test task configuration from 9 individual module build.gradle.kts files into a single centralized block in the root build.gradle.kts under subprojects { }. This is a good maintainability improvement that follows the DRY principle.

Changes Reviewed

File Changes
build.gradle.kts Added centralized test configuration in subprojects block
gradle.properties Added -XX:+HeapDumpOnOutOfMemoryError JVM flag
9 module build files Removed duplicate test configuration blocks

Key Details

  1. Test Configuration Centralization: All common test settings (useJUnitPlatform, forkEvery, maxHeapSize, maxParallelForks, jvmArgs) are now defined once in the root build.gradle.kts.

  2. forkEvery Optimization: Increased from 100 to 500 to reduce JVM restarts during test execution, which should improve test performance.

  3. maxHeapSize: The 2g heap size setting is preserved in the centralized configuration.

  4. Heap Dump Flag: Added -XX:+HeapDumpOnOutOfMemoryError to gradle.properties for better debugging of OOM issues.

  5. Module-Specific Config: The ui module correctly retains its test task block containing only the module-specific android.sourceSets configuration.

Verification

  • All common test settings are properly centralized
  • Module-specific configurations are preserved where needed
  • The @Suppress("UselessCallOnNotNull") annotation on jvmArgs.orEmpty() is appropriate

No issues identified.


🤖 Generated with Claude Code

tasks.withType<Test>().configureEach {
useJUnitPlatform()
@Suppress("MagicNumber")
forkEvery = 500
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have moved the test configs to this singular spot for convenience but there are also some small changes too.

  • I have increased the forkEvery count to avoid spinning up so many JVM instances
  • I have completely removed the maxHeapSize property to allow the jvm args from the gradle.properties to handle it (-Xmx4g).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! @LRNcardozoWDF this may help the extra resource consumption you were noticing.

org.gradle.caching=true
org.gradle.configuration-cache=true
org.gradle.configuration-cache.parallel=true
org.gradle.configuration-cache.problems=warn
Copy link
Collaborator Author

@david-livefront david-livefront Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required for some warnings coming from the configuration on release builds.

Thoughts on if we should just remove the configuration cache completely?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the configuration cache completely will probably increase build times, so I'm hesitant to go that route. What are the warnings you are seeing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

Logo
Checkmarx One – Scan Summary & Details86311c28-3df0-4b72-86bd-dca82de456dc

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.77%. Comparing base (0d0a5cb) to head (279ba56).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6433   +/-   ##
=======================================
  Coverage   85.77%   85.77%           
=======================================
  Files         775      775           
  Lines       56203    56203           
  Branches     8123     8123           
=======================================
  Hits        48207    48207           
  Misses       5172     5172           
  Partials     2824     2824           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:feature-tool Change Type - Internal tool feature or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants