[PM-31393] Sends: UI/UX inconsistency of the password field

[shamim-emon]

🎟️ Tracking

#6335

📔 Objective

Adds the ability to generate and copy passwords under the Send tab.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[bitwarden-bot]

Thank you for your contribution! We've added this to our internal tracking system for review.
ID: PM-31393
Link: https://bitwarden.atlassian.net/browse/PM-31393

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

[david-livefront]

Can we make this a little safer:

(action.generatorResult as? GeneratorResult.Password)?.let { passwordData ->
    updateCommonContent {
        it.copy(passwordInput = passwordData.password)
    }
}

[shamim-emon]

@david-livefront done!

[SaintPatrck]

@shamim-emon Our design and product teams are reviewing the screen changes. In the meantime, can you update tests to cover these changes?

[shamim-emon]

@shamim-emon Our design and product teams are reviewing the screen changes. In the meantime, can you update tests to cover these changes?

@SaintPatrck I have added test coverage for these changes. Please have a look and let me know if anything else is needed from my side.
Thank you