Skip to content

Conversation

@vvolkgang
Copy link
Member

@vvolkgang vvolkgang commented Jan 29, 2026

🎟️ Tracking

PM-31292

📔 Objective

Update renovate config to:

  1. Open individual PRs for all gradle dependencies
  2. Ignore SDK updates - handled by our custom workflow.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang added the ai-review Request a Claude code review label Jan 29, 2026
@github-actions github-actions bot added the t:ci Change Type - Updates to automated workflows label Jan 29, 2026
@claude
Copy link
Contributor

claude bot commented Jan 29, 2026

Claude finished @vvolkgang's task in 57s —— View job


Code Review Summary

PR: #6437 - PM-31292 ci: update renovate config to remove gradle group and ignore sdk updates
Author: @vvolkgang
Status: Approved


Overview

This PR modifies the Renovate configuration to:

  1. Add com.bitwarden:sdk-android to ignoreDeps - SDK updates are now completely ignored since they're handled by a custom workflow
  2. Remove the "gradle minor" grouping rule - gradle dependencies will now receive individual PRs instead of being batched together

Analysis

Area Assessment
Correctness Valid JSON configuration that achieves stated objectives
Risk Level Low - CI/CD configuration only, no application code changes
Breaking Changes None

Findings

No issues identified.

Notes:

  • The JSON syntax is valid
  • The ignoreDeps approach is cleaner than the previous exclusion within the group rule
  • Removing the gradle grouping provides better granularity for reviewing dependency updates individually
  • The previously excluded com.github.bumptech.glide:compose is no longer special-cased, but this is appropriate since each gradle dependency now gets its own PR anyway

PM-31292

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.77%. Comparing base (ca9ec45) to head (f62af1f).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6437      +/-   ##
==========================================
+ Coverage   85.49%   85.77%   +0.27%     
==========================================
  Files         776      775       -1     
  Lines       56116    56203      +87     
  Branches     8121     8123       +2     
==========================================
+ Hits        47977    48207     +230     
+ Misses       5323     5172     -151     
- Partials     2816     2824       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details558d64f3-cb0e-44c0-96bb-ce1cf12fa1c6

Great job! No new security vulnerabilities introduced in this pull request

"extends": [
"github>bitwarden/renovate-config"
],
"ignoreDeps": ["com.bitwarden:sdk-android"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vvolkgang vvolkgang marked this pull request as ready for review January 29, 2026 21:06
@vvolkgang vvolkgang requested a review from a team as a code owner January 29, 2026 21:06
@vvolkgang vvolkgang added this pull request to the merge queue Jan 29, 2026
Merged via the queue into main with commit f541919 Jan 29, 2026
22 checks passed
@vvolkgang vvolkgang deleted the vvolkgang/renovate-config branch January 29, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:ci Change Type - Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants