Open
Conversation
Member
CascadingRadium
commented
Nov 5, 2025
- If optimization level is not specified, force usage of "generic"
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the incorrect declaration of FAISS_OPT_LEVEL in the CMake configuration. Previously, it was defined using option() which is meant for boolean values, but it should accept string values for different optimization levels (generic, avx2, avx512, etc.). The fix replaces the option() with a proper conditional string cache variable.
- Changed
FAISS_OPT_LEVELfrom anoption()to aCACHE STRINGvariable - Added conditional check to only set the variable if not already defined
- Duplicated the comment line explaining valid values
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abhinavdangeti
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.