Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the BlessCrawl module by removing unused FFI functions and their corresponding mock implementations and replaces the FFI-based logic in the map and crawl methods with simple placeholder implementations.
- Removed FFI functions and their mocks from the extern "C" block and the mock_ffi module.
- Refactored the map and crawl methods to return default/empty responses with placeholder TODO comments.
Joinhack
approved these changes
Jun 27, 2025
uditdc
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request simplifies the
BlessCrawlmodule by removing unused FFI functions (mapandcrawl) and their corresponding implementations. It also refactors themapandcrawlmethods in theBlessCrawlstruct to provide placeholder implementations instead of relying on the removed FFI functions.Removal of FFI functions:
mapandcrawlfunctions from the FFI interface in theextern "C"block, as they are no longer used. (src/bless_crawl/mod.rs, src/bless_crawl/mod.rsL43-L68)mapandcrawlfunctions from themock_ffimodule. (src/bless_crawl/mod.rs, src/bless_crawl/mod.rsL92-L119)Refactoring of
BlessCrawlmethods:mapmethod to remove the FFI-based implementation and replace it with a placeholder that returns an emptyMapDataresponse. (src/bless_crawl/mod.rs, src/bless_crawl/mod.rsL528-R488)crawlmethod to remove the FFI-based implementation and replace it with a placeholder that returns an emptyCrawlDataresponse. (src/bless_crawl/mod.rs, src/bless_crawl/mod.rsL586-L662)