Fix static linking of protobuf and pre-build perf tester#116
Merged
michalovits merged 1 commit intoMay 28, 2026
Conversation
Restore `set(Protobuf_USE_STATIC_LIBS ON)` in authproto/CMakeLists.txt. This was inadvertently removed in PR bloomberg#114 when modernising the find_package call. Without it, protobuf is linked dynamically, causing runtime failures on systems without the shared library installed. Also pre-build the Rust performance tester binary in the integration Dockerfile and require the PERF_TESTER_BIN environment variable in integration-tests.py. This avoids needing a full Rust toolchain in the test runtime environment and gives explicit control over the binary being tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore
set(Protobuf_USE_STATIC_LIBS ON)in authproto/CMakeLists.txt. This was inadvertently removed in PR #114 when modernising the find_package call. Without it, protobuf is linked dynamically, causing runtime failures on systems without the shared library installed.Also pre-build the Rust performance tester binary in the integration Dockerfile and require the PERF_TESTER_BIN environment variable in integration-tests.py. This avoids needing a full Rust toolchain in the test runtime environment and gives explicit control over the binary being tested.