fix(git): serialize concurrent pushes and refresh refs to avoid stale state#76
Open
karnirathorewolf wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the reliability of concurrent git operations by ensuring that each repo and ref pair is handled safely, preventing race conditions and stale state issues. The most important changes are:
Concurrency control for git operations:
pushLocksfield in thePoolstruct to serialize handler execution perrepo:refpair, preventing concurrent goroutines from racing on git push to the same branch. (task/pool.go)Dispatchmethod, added logic to acquire and release a mutex for eachrepo:refpair, ensuring that only one handler operates on a given branch at a time. (task/pool.go)Ensuring up-to-date git state:
Refreshfunction to the git bindings that fetches the latest state of a ref from origin (shallow, depth 1), to avoid using stale local state. (git/bindings.go)KoboldHandler, now callsgit.Refreshbefore switching branches to ensure the latest remote state is fetched, reducing the risk of push rejections due to outdated data. (task/handler.go)related to issue fixes #71