Skip to content

[PW_SID:1079876] [v2,net-next] Bluetooth: hci_conn: fix potential UAF in create_big_sync #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BluezTestBot wants to merge 1 commit into from
Closed

[PW_SID:1079876] [v2,net-next] Bluetooth: hci_conn: fix potential UAF in create_big_sync #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions net/bluetooth/hci_conn.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2130,6 +2130,9 @@ static int create_big_sync(struct hci_dev *hdev, void *data)
u32 flags = 0;
int err;

if (!hci_conn_valid(hdev, conn))
return -ECANCELED;

if (qos->bcast.out.phys == BIT(1))
flags |= MGMT_ADV_FLAG_SEC_2M;

Expand Down Expand Up @@ -2204,11 +2207,22 @@ static void create_big_complete(struct hci_dev *hdev, void *data, int err)

bt_dev_dbg(hdev, "conn %p", conn);

if (err == -ECANCELED)
return;

hci_dev_lock(hdev);

if (!hci_conn_valid(hdev, conn))
goto done;

if (err) {
bt_dev_err(hdev, "Unable to create BIG: %d", err);
hci_connect_cfm(conn, err);
hci_conn_del(conn);
}

done:
hci_dev_unlock(hdev);
}

struct hci_conn *hci_bind_bis(struct hci_dev *hdev, bdaddr_t *dst, __u8 sid,
Expand Down
Loading