Skip to content

- refactor code#25

Merged
krzysztofrewak merged 3 commits intoblumilksoftware:mainfrom
fork-contributions:refactor_code
Mar 18, 2025
Merged

- refactor code#25
krzysztofrewak merged 3 commits intoblumilksoftware:mainfrom
fork-contributions:refactor_code

Conversation

@perisicnikola37
Copy link
Copy Markdown
Contributor

@perisicnikola37 perisicnikola37 commented Jan 22, 2025

Changes

README.md file

  • Updated dates (from 2022 to 2025
  • Added additional missing section "Customizing the Heatmap Builder watching period"

Code

  • Fixed composer "test" script
  • Added constants in PeriodActions.php file
  • Added ternary operator on the description property in Tile.php file
  • Created new generic method setPeriodFromDuration in Tile.php file

@perisicnikola37
Copy link
Copy Markdown
Contributor Author

@BarTracz @krzysztofrewak

Copy link
Copy Markdown
Member

@krzysztofrewak krzysztofrewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for your pull request! Please check my comments and try to implement requested changes.

@perisicnikola37
Copy link
Copy Markdown
Contributor Author

Hi! Check now.
@krzysztofrewak

@krzysztofrewak krzysztofrewak changed the title Refactor code - refactor code Mar 18, 2025
@krzysztofrewak krzysztofrewak merged commit 5f38645 into blumilksoftware:main Mar 18, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants