Open
Conversation
- Update gettext dependency from ~> 0.20 to ~> 0.26 - Enables access to modern backend API features - Prepares for configuration modernization
- Replace deprecated `use Gettext, otp_app:` with `use Gettext.Backend, otp_app:` - Update import statements to use `use Gettext, backend:` pattern - Remove compilation warnings about outdated gettext usage - Leverages modern API now available in 0.26 series
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR upgrades the project’s Gettext integration to the modern 0.26+ API by bumping the dependency, switching the backend macro, migrating old imports to the new use-based pattern, and updating documentation examples accordingly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernize Gettext configuration in storybook to eliminate deprecation warnings and improve compile-time performance.
Changes
~> 0.20to~> 0.26use Gettext, otp_app:→use Gettext.Backend, otp_app:import SaladStorybookWeb.Gettext→use Gettext, backend: SaladStorybookWeb.GettextBenefits
Notes
Gettext 1.0.0 was recently released with no breaking changes from 0.26.x. We can consider upgrading to 1.0 in a future update.
Summary by Sourcery
Modernize the Storybook Phoenix app’s Gettext setup by upgrading the dependency and switching to the new backend API to remove deprecation warnings and improve compile-time performance.
Enhancements: