Open
Conversation
mathildepm
reviewed
Sep 15, 2021
Contributor
mathildepm
left a comment
mathildepm
left a comment
There was a problem hiding this comment.
LGTM!
Idk why some tests are running so we'll see when you push again.
Let's revert committee.py to what it was before since we aren't worried about that:
https://dev.to/lofiandcode/git-and-github-how-to-revert-a-single-file-dha
| failed_uploads.append(row) | ||
| if failed_uploads: | ||
| messages.error( | ||
| request, 'Not all secretariat members could upload. These rows failed: ' |
Contributor
There was a problem hiding this comment.
Suggested change
| request, 'Not all secretariat members could upload. These rows failed: ' | |
| request, 'Not all Committees could upload. These rows failed: ' |
Contributor
There was a problem hiding this comment.
JK let's just revert this file
Contributor
|
ALSO; let's update the PR description so it describes more accurately what the PR is doing
|
Contributor
|
We were looking through this code for huxley notes app and realized that we should also be validating emails in load so that should be a todo. |
Contributor
|
Here's a reference to the commit in huxley notes app in delegate.py's load method for the email check: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#734 This issue prevented errors when headers in CSV files were present. Also added HTML error messages on failed uploads to specify which rows could not be matched to existing schools or committees.