Issue 763 - Changed relevant HTML anchors to use Button components instead#774
Open
skberkeley wants to merge 5 commits intomasterfrom
Open
Issue 763 - Changed relevant HTML anchors to use Button components instead#774skberkeley wants to merge 5 commits intomasterfrom
skberkeley wants to merge 5 commits intomasterfrom
Conversation
srisainachuri
requested changes
Nov 28, 2021
Contributor
srisainachuri
left a comment
srisainachuri
left a comment
There was a problem hiding this comment.
Missing some imports and issues with variable names, but the general construction of the components looked fine
| size="large" | ||
| href={gradedHrefData} | ||
| download={gradedName} | ||
| download={gradedFileName} |
Contributor
There was a problem hiding this comment.
The variable gradedFileName is not defined, did you mean to rename gradedName?
| "button-blue": true, | ||
| "rounded-small": true, | ||
| })} | ||
| <Button |
Contributor
There was a problem hiding this comment.
Missing import to Button at the top of the file
Contributor
Author
There was a problem hiding this comment.
I think line 8 const { Button } = require("components/core/Button"); should work, since other Button components from previous commits use that
| "button-green": true, | ||
| "rounded-small": true, | ||
| })} | ||
| <Button |
Contributor
There was a problem hiding this comment.
also missing Button import I believe, but looks good otherwise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested the front end components corresponding to the modified files to make sure they all looked the same and all the buttons still downloaded the relevant files properly