Uv context#4
Open
refack wants to merge 2 commits intobnoordhuis:uv-context-idfrom
node4good:uv-context-id
Open
Uv context#4refack wants to merge 2 commits intobnoordhuis:uv-context-idfrom node4good:uv-context-id
refack wants to merge 2 commits intobnoordhuis:uv-context-idfrom
node4good:uv-context-id
Conversation
bnoordhuis
force-pushed
the
uv-context-id
branch
from
af669a5 to
048125b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things:
_idtoIncomingMessage. It's great for tracing (and for your health in general :)async-wrap-inl.h. It's probably leaky or some other horrible thing, but I want to learn.