Publish releases automatically with native notes#175
Conversation
📝 WalkthroughWalkthroughThe GoReleaser ChangesDraft-to-published release switch
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Bomly Diff SummaryCompared Overview
Dependency Changes✅ No dependency changes. Vulnerabilities✅ No vulnerability changes. License Changes✅ No license changes. Project Posture✅ No project posture changes (or Policy Findings✅ No policy differences were identified. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/ARCHITECTURE.md`:
- Line 195: The behavior change at line 195 describing Semver tags running
GoReleaser is documented, but the design rationale for why Auto Version tag
creation serves as the manual approval gate is not captured in the decision log
section of the ARCHITECTURE.md file. Add a decision-log entry in
docs/ARCHITECTURE.md that explicitly documents this non-obvious design choice,
explaining that Auto Version tag creation is the designated manual approval gate
for the release workflow and why this design decision was made. This ensures
future developers understand the intentional release approval boundary without
having to infer it from the behavior description alone.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 8fc4a4c4-cf2a-45cc-b496-b2988a82121d
📒 Files selected for processing (4)
.goreleaser.yamldocs/ARCHITECTURE.mddocs/development/CI.mddocs/development/RELEASE_CHECKLIST.md
| - Pull requests run fast validation only. | ||
| - Pushes to `main` run deeper quality checks and scheduled smoke coverage. | ||
| - Semver tags run GoReleaser to publish draft GitHub Releases with cross-platform archives, `SHA256SUMS`, Linux packages, and package-manager manifests. | ||
| - Semver tags run GoReleaser to publish GitHub Releases with GitHub-native release notes, cross-platform archives, `SHA256SUMS`, Linux packages, and package-manager manifests. |
There was a problem hiding this comment.
Add a decision-log entry for the release approval boundary change.
At Line 195, the behavior change is documented, but the non-obvious design choice (“Auto Version tag creation is the manual approval gate”) is not captured in the Architecture decision log.
As per coding guidelines, "Update docs/ARCHITECTURE.md with pipeline diagram changes when the stage list changes and add decision-log entries for non-obvious design choices."
Suggested doc addition
+### Decision: Tag creation is the manual release approval gate
+
+The manual approval boundary for releases is running `Auto Version`, which creates the semver tag.
+After release-workflow validation, GoReleaser publishes the GitHub Release automatically so package-manager PRs can reference public assets and checksums immediately.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/ARCHITECTURE.md` at line 195, The behavior change at line 195 describing
Semver tags running GoReleaser is documented, but the design rationale for why
Auto Version tag creation serves as the manual approval gate is not captured in
the decision log section of the ARCHITECTURE.md file. Add a decision-log entry
in docs/ARCHITECTURE.md that explicitly documents this non-obvious design
choice, explaining that Auto Version tag creation is the designated manual
approval gate for the release workflow and why this design decision was made.
This ensures future developers understand the intentional release approval
boundary without having to infer it from the behavior description alone.
Source: Coding guidelines
841a13a to
c75b4e5
Compare
Summary
Auto Versiontag workflow as the manual approval gateThis makes release assets public before package-manager PR validation, which avoids WinGet PR failures caused by missing public release files.
Security notes
Validation
/Users/ahmed/go/bin/goreleaser checkgit diff --checkmake testgo vet ./.../Users/ahmed/go/bin/goreleaser release --snapshot --clean --skip=publishSummary by CodeRabbit