Revise the release lifecycle yanking workflow#178
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe release lifecycle workflow is renamed to ChangesRelease lifecycle sync workflow and docs
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Bomly Diff SummaryCompared Overview
Dependency ChangesSummary: 1 added, 0 changed, 0 removed. Added Dependencies
Vulnerabilities✅ No vulnerability changes. License Changes✅ No license changes. Project Posture✅ No project posture changes (or Policy Findings✅ No policy differences were identified. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/notify-landing-yank.yml:
- Around line 66-74: In the "Check out WinGet package manifests" step that uses
actions/checkout, add the persist-credentials field set to false to prevent
credential leakage through workflow artifacts. Additionally, replace the tag
reference `@v5` with a pinned commit SHA (format: actions/checkout@<commit-sha>)
to mitigate supply chain attack risks from using mutable tag references.
- Line 28: In the `actions/create-github-app-token@v3` step configuration,
change the parameter from `app-id` to `client-id` and update its value to use
only `vars.RELEASE_BOT_CLIENT_ID` without the fallback to
`vars.RELEASE_BOT_APP_ID`. This aligns the workflow with the consistent pattern
used in `release.yml` and `auto-version.yml` and ensures the correct parameter
type is provided to the action.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: eb3bc047-af05-484f-bab2-31d637c66988
📒 Files selected for processing (3)
.github/workflows/notify-landing-yank.ymldocs/development/CI.mddocs/development/RELEASE_CHECKLIST.md
Comment on lines
+66
to
+74
| - name: Check out WinGet package manifests | ||
| uses: actions/checkout@v5 | ||
| with: | ||
| repository: microsoft/winget-pkgs | ||
| ref: master | ||
| path: winget-pkgs | ||
| sparse-checkout: manifests/b/Bomly/BomlyCLI | ||
| sparse-checkout-cone-mode: false | ||
| fetch-depth: 1 |
Contributor
There was a problem hiding this comment.
Add persist-credentials: false and consider pinning the action to a SHA.
Static analysis correctly flags two security concerns:
- Missing
persist-credentials: false— the defaulttruecan leak credentials via workflow artifacts. - Action referenced by tag (
@v5) rather than hash — pinning to a SHA (e.g.,@<commit-sha>) hardens against supply chain attacks.
🛡️ Proposed fix
- name: Check out WinGet package manifests
- uses: actions/checkout@v5
+ uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v5.0.2
with:
repository: microsoft/winget-pkgs
ref: master
path: winget-pkgs
sparse-checkout: manifests/b/Bomly/BomlyCLI
sparse-checkout-cone-mode: false
fetch-depth: 1
+ persist-credentials: false🧰 Tools
🪛 zizmor (1.25.2)
[warning] 66-74: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false
(artipacked)
[error] 67-67: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy)
(unpinned-uses)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/notify-landing-yank.yml around lines 66 - 74, In the
"Check out WinGet package manifests" step that uses actions/checkout, add the
persist-credentials field set to false to prevent credential leakage through
workflow artifacts. Additionally, replace the tag reference `@v5` with a pinned
commit SHA (format: actions/checkout@<commit-sha>) to mitigate supply chain
attack risks from using mutable tag references.
Source: Linters/SAST tools
bomly-guy
force-pushed
the
codex/revise-yanking-workflow
branch
from
bd2ab05 to
fb7c712
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Summary by CodeRabbit
New Features
Documentation