Handle empty path expansion#236
Open
QuantumEntangledAndy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting an issue on Linux specifically
Investigation showed that
browser_cookie3/browser_cookie3/__init__.py
Lines 469 to 474 in 0389579
has an empty path for
linux_cookiesfor browsers such asArcwhich is I believe correct since there is no linux path for this browserThe issue is that the current implementation tries all browsers and for any browser where the linuxpath is not set it would error for linux.
To fix this I altered
_expand_path_implto handle empty (i.e. None) as an empty list insteadbrowser_cookie3/browser_cookie3/__init__.py
Lines 130 to 133 in 0389579