This repository was archived by the owner on Sep 6, 2020. It is now read-only.
Fix the composer autoloader location for cgr#164
Open
mikeSimonson wants to merge 1 commit intobox-project:2.0from
Open
Fix the composer autoloader location for cgr#164mikeSimonson wants to merge 1 commit intobox-project:2.0from
mikeSimonson wants to merge 1 commit intobox-project:2.0from
Conversation
There is a tool called cgr (for composer global require) that install every tool that needs to be globaly available in their own custom folder. It does so that each tool dependecy don't infuences other tools dependencies. This means that the logic that was previously used by the autoloader location code for box is broken. For some reason the code used to look for the last autoloader in the folder structure ( the one closest to the root folder ). I have no idea why it was doing so. For cgr to work it needs to be the first one found that needs to be used. I have changed the logic accordingly in this PR as well as removed some dead code (an option that was never used).
Member
|
Ping @kherge: this actually makes much more sense as you're likely to want the first vendor (which 99% will be your project one) and not the most global one. |
Member
Author
|
@theofidry Thanks. Is humbug fork the main repo now ? |
Member
|
@mikeSimonson yeah. Well at least I'm working on it as I couldn't get hold on Keven Herrera to access to this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a tool called cgr (for composer global require) that
install every tool that needs to be globaly available in their own
custom folder. It does so that each tool dependecy don't infuences
other tools dependencies.
This means that the logic that was previously used by the autoloader
location code for box is broken. For some reason the code used to look
for the last autoloader in the folder structure ( the one closest to
the root folder ). I have no idea why it was doing so.
For cgr to work it needs to be the first one found that needs to be
used. I have changed the logic accordingly in this PR as well as
removed some dead code (an option that was never used).
Any comment ?