build(deps-dev): bump @storybook/addon-onboarding from 8.4.4 to 10.3.5#447
build(deps-dev): bump @storybook/addon-onboarding from 8.4.4 to 10.3.5#447dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
ManiruzzamanAkash
force-pushed
the
dependabot/npm_and_yarn/dev/storybook/addon-onboarding-10.3.5
branch
from
5969ed7 to
07facf0
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1,70 +1,70 @@ | |||
| import type { StorybookConfig } from '@storybook/react-vite'; | |||
There was a problem hiding this comment.
What: The imports in the updated configuration are unchanged but are formatted with carriage return characters, which may cause issues in cross-platform compatibility.
Why: Using the right line endings is essential to prevent unexpected behavior in different environments, especially when collaborating with other developers or CI/CD systems.
How: Consider configuring your editor to use Unix-style line endings (LF) consistently, or use a tool like dos2unix to convert the file.
| }, | ||
| }; | ||
| export default config; | ||
| import type { StorybookConfig } from '@storybook/react-vite'; |
There was a problem hiding this comment.
What: Ensure that the Storybook configuration correctly aligns with the latest Storybook version documentation, especially regarding the use of @storybook/react-vite instead of @storybook/react-webpack5. This may affect compatibility with certain features.
Why: Upgrading to the latest version may introduce breaking changes; hence, reviewing the configuration against the latest documentation is vital for maintaining functionality and performance.
How: Review the official documentation for Storybook and adapt any necessary properties within the configuration to cater to the current version you have upgraded to.
| '@chromatic-com/storybook', | ||
| '@storybook/addon-interactions', | ||
| '@storybook/addon-a11y', | ||
| ], |
There was a problem hiding this comment.
What: The filtering mechanism for plugins seems thorough, but consider logging or error handling for troubleshooting in case a needed plugin is unintentionally filtered out.
Why: Implementing checks will help in identifying potential issues during development or runtime and address them promptly.
How: Add console log statements before and after filtering the plugins to log which plugins are being removed, which could help during debugging.
| }), | ||
| ]; | ||
| return mergeConfig(config, { |
There was a problem hiding this comment.
What: Consider adding types for the mergeConfig function for better TypeScript integration, which will enhance the maintaining process of the code.
Why: Explicitly typed functions and variables help catch errors early and improve code readability.
How: Import the required Vite types or define your own types that match the expected structure of config being merged.
| alias: { | ||
| ...config.resolve?.alias, | ||
| // 👇 Internal modules | ||
| '@/icons': path.resolve( |
There was a problem hiding this comment.
What: The alias paths are defined directly but could benefit from checking if the paths indeed resolve to valid files before configuration.
Why: This could avoid runtime errors when Storybook tries to resolve these paths, which may cause the application to break if not handled.
How: Consider implementing a check using fs.existsSync to confirm that each path corresponds to an existing directory or file.
| @@ -1,30 +1,30 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
What: Consider avoiding disabling color-contrast checks entirely for accessibility.
Why: Disabling color-contrast checks can lead to accessibility issues for users with visual impairments. Maintaining color contrast is crucial for readability and usability on various devices.
How: Instead of disabling color-contrast checks, consider setting appropriate color contrast values or guidelines that comply with accessibility standards.
| (Story) => ( | ||
| <div className="[&_*]:[font-family:Figtree,sans-serif] [&_*]:box-border"> | ||
| <Story /> | ||
| </div> |
There was a problem hiding this comment.
What: Review the custom font styles to ensure they are applied correctly across components.
Why: Improper handling of font styles could lead to inconsistent UI rendering, impacting the visual integrity of the application.
How: Double-check the CSS class definitions for font-family and make sure that the Figtree font is properly imported and loaded in the application.
| }; | ||
|
|
||
| export default preview; | ||
| import React from 'react'; |
There was a problem hiding this comment.
What: Ensure that the latest version of Storybook is compatible with your configuration settings.
Why: Using an outdated configuration with a new version of Storybook may lead to unexpected bugs or performance issues.
How: Check the official Storybook documentation specific to the version you are using for any updates or breaking changes that may affect how previews are structured.
| @@ -1,30 +1,30 @@ | |||
| const { getStoryContext } = require('@storybook/test-runner'); | |||
There was a problem hiding this comment.
What: The import statements remain unchanged but are now followed by carriage return characters, potentially leading to inconsistent line endings.
Why: Inconsistent line endings might lead to compatibility issues across different environments and can complicate version control diffs.
How: Ensure that the code adheres to a consistent line ending style throughout the file. You can set your text editor or IDE to use only LF (Unix style) or CRLF (Windows style) line endings consistently.
| }, | ||
| }); | ||
| }, | ||
| }; |
There was a problem hiding this comment.
What: The updated code does not have any clear performance or security issues based on the diff provided.
Why: The changes focus on restructuring the same functionality without introducing new logic that could lead to security vulnerabilities or performance problems.
How: Continue to monitor dependencies such as 'axe-playwright' and ensure that they are updated regularly to mitigate any potential vulnerabilities that could arise as they evolve.
Bumps @storybook/addon-onboarding from 8.4.4 to 10.3.5.
Changelog
Sourced from
@storybook/addon-onboarding's changelog.... (truncated)
Commits
e486d38Bump version from "10.3.4" to "10.3.5" [skip ci]4eff9cdBump version from "10.3.3" to "10.3.4" [skip ci]b0acfb4Bump version from "10.3.2" to "10.3.3" [skip ci]308656fBump version from "10.3.1" to "10.3.2" [skip ci]24c2c2cBump version from "10.3.0" to "10.3.1" [skip ci]06cb6a6Bump version from "10.3.0-beta.3" to "10.3.0" [skip ci]94b9430Bump version from "10.3.0-beta.2" to "10.3.0-beta.3" [skip ci]af5b7deBump version from "10.3.0-beta.1" to "10.3.0-beta.2" [skip ci]9e58af5Merge branch 'next' into sidnioulz/issue-31678-aria-disabled-finisha571619Bump version from "10.3.0-beta.0" to "10.3.0-beta.1" [skip ci]Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for
@storybook/addon-onboardingsince your current version.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)