Add an inline search variant for the Combobox#449
Open
jaieds wants to merge 6 commits into
Open
Conversation
- Add `inlineSearch` prop: renders search input inside the trigger instead of the dropdown. Selected items show as badges (multi) or as the input value (single). Mutually exclusive with `combobox`. - Wire floating-ui combobox pattern: input is the interactive reference, wrapper div is the position reference. `virtual: true` in useListNavigation so items use aria-activedescendant without stealing DOM focus. - UX polish: selected label shown in input on open (no highlight), typing appends and filters, search clears on any close (Escape, outside-click, or selection), Backspace removes last badge in multi mode. - Add InlineSearchSingle, InlineSearchMulti, InlineSearchWithCombobox stories with interaction test coverage. - Update readme.md and select-types.ts for new prop.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ManiruzzamanAkash
force-pushed
the
select-component/inline-search
branch
from
fc784ca to
2098698
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshots | Video with voice-over
Link to Figma (If applicable)
How has this been tested?
Checklist: