-
Notifications
You must be signed in to change notification settings - Fork 1
feat(editor-input): replace Lexical with TipTap + v1.7 backward-compat shim #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jaieds
wants to merge
9
commits into
staging
Choose a base branch
from
editor-input-component
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
fa2dca6
refactor(editor-input): replace Lexical with TipTap for mention/varia…
jaieds 28e7e99
fix(editor-input): scroll selected suggestion item into view on arrow…
jaieds 25345e1
fix(editor-input): add 8px gap between input and suggestion dropdown
jaieds c80952d
fix(editor-input): align suggestion dropdown width with input border
jaieds f2df720
fix(build): externalise @tiptap/* and prosemirror* packages in rollup…
jaieds 5525514
feat(editor-input): add valueFormat prop for v1.7 Lexical backward co…
jaieds 672ec60
fix(editor-input): restore empty-label guard in mention filter
jaieds ea65d6e
fix(editor-input): align placeholder with caret on first line
jaieds 9e52359
docs(editor-input): add 1.8.0 changelog entry and Storybook migration…
jaieds File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 0 additions & 71 deletions
71
src/components/editor-input/character-limit-plugin/character-limit.tsx
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What: The package versions should be reviewed and locked to specific minor versions if stability is a concern.
Why: Using caret (^) with versions can lead to potential breaking changes when updating dependencies to newer versions, potentially causing issues in production.
How: Consider changing the dependencies to specific minor versions (e.g. "@tiptap/core": "3.23.2" instead of "^3.23.2") or ensure that the package is tested well with the latest versions before releasing.