Skip to content

Create instrumentation_tests.yml#135

Merged
buzzamus merged 4 commits into
mainfrom
run-instrumentation-tests-in-ci
Apr 28, 2026
Merged

Create instrumentation_tests.yml#135
buzzamus merged 4 commits into
mainfrom
run-instrumentation-tests-in-ci

Conversation

@buzzamus
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Braintree.

Summary of changes

  • Created GitHub Actions Instrumentation Tests workflow to run instrumentation tests in CI

AI Usage

Which AI Agent Was Used?

  • Copilot
  • Claude
  • Other (Type Name Here)

How was AI used?
Had Claude use the instrumentation tests workflow yaml file from Braintree Android repo to create similar workflow for this repo's instrumentation tests

Estimated AI Code Contribution

  • less than 30%
  • 30 - 60%
  • 60 - 100%

Checklist

  • Added a changelog entry
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

List GitHub usernames for everyone who contributed to this pull request.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 27, 2026

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
See the Details below.

Scanned Files

  • .github/workflows/instrumentation_tests.yml

@buzzamus buzzamus marked this pull request as ready for review April 28, 2026 14:47
@buzzamus buzzamus requested a review from a team April 28, 2026 14:47
@noguier
Copy link
Copy Markdown
Contributor

noguier commented Apr 28, 2026

I see you removed the some APIs, there were no way to make the 23 and google apis work? Just curious

@buzzamus
Copy link
Copy Markdown
Contributor Author

I see you removed the some APIs, there were no way to make the 23 and google apis work? Just curious

I was able to get the other Google API version numbers to work, but API 23 I believe is having difficulty discovering UI elements due to differences in the older API version

@noguier
Copy link
Copy Markdown
Contributor

noguier commented Apr 28, 2026

I think we are good to go without api 23 then, thank you!

arch: x86_64
profile: pixel_7_pro
script: |
adb shell 'echo "_ --disable-fre --no-default-browser-check --no-first-run" > /data/local/tmp/chrome-command-line'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind giving me some context why we needed to add shell commands to our running script, I am just curious.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Of course: This is to get around the first time Chrome is launched bring up the "Terms of Service" popup that blocks the text the test is looking for, so it essentially launches Chrome as if it has already been launched before

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, smart!

Copy link
Copy Markdown

@saralvasquez saralvasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and also looks like the run and retry are working as expected. I think it's good to go in!

@buzzamus buzzamus merged commit 6ba8684 into main Apr 28, 2026
13 of 14 checks passed
@buzzamus buzzamus deleted the run-instrumentation-tests-in-ci branch April 28, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants