Skip to content

Add CEL-compliant pod security and storage settings#83

Open
JPurcell-Braintrust wants to merge 7 commits into
mainfrom
james/security-enhancements
Open

Add CEL-compliant pod security and storage settings#83
JPurcell-Braintrust wants to merge 7 commits into
mainfrom
james/security-enhancements

Conversation

@JPurcell-Braintrust
Copy link
Copy Markdown

@JPurcell-Braintrust JPurcell-Braintrust commented May 5, 2026

Adding in the previous security enhancements to satisfy CEL based policies, previously based on 1.1.32 to the latest helm updates. The security enhancements were:

  • add securityContext and podSecurityContext to all 3 pod types
  • readOnlyRootFilesystem
  • emptyDir size limits for Brainstore volumes

An example/google-autopilot-cel/ has been created to help the known customers currently needing these CEL enhancements in their production environment.

@soldatchenko
Copy link
Copy Markdown
Contributor

Overall this looks good to me. My only asks are around runtime validation rather than the Helm config itself

  • confirm the read-only root filesystem with representative API/scorer + Brainstore trace paths
  • make sure the Brainstore emptyDir.sizeLimit leaves enough headroom above the configured cache size in the example

Comment thread braintrust/examples/google-autopilot-cel/values.yaml
Comment thread braintrust/examples/google-autopilot-cel/values.yaml
Comment thread braintrust/examples/google-autopilot-cel/values.yaml
Comment thread braintrust/templates/brainstore-fastreader-deployment.yaml Outdated
@soldatchenko
Copy link
Copy Markdown
Contributor

Please make sure that the PR title is descriptive, and the comments make it easy for a customer/consumer of this chart to understand what changes are being made. A few examples:

It will forever be immortalized in the public commit history and release notes.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now, thanks for addressing all the comments!

Note

  • This does include the EKS quarantine example, make sure you truly want it in this commit and eventual release

@soldatchenko
Copy link
Copy Markdown
Contributor

Also the Helm unit test CI is failing during helm-unittest plugin installation, before any chart tests run, due to an unstable/unpinned plugin install path.

@JPurcell-Braintrust JPurcell-Braintrust changed the title James/security enhancements CEL policy update CEL policy fixes (readOnlyRootFilesystem & emptyDir size limits) May 15, 2026
@JPurcell-Braintrust JPurcell-Braintrust changed the title CEL policy fixes (readOnlyRootFilesystem & emptyDir size limits) Add CEL-compliant pod security and storage settings May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants