Add ANN#11
Open
Ankur Goyal (ankrgyl) wants to merge 11 commits into
Open
Conversation
* initial commit * support named vectors * optimize format * clustering example * Vector -> VectorMap * fix build * tests * change to batch interface * bump * fix * cache presence bits and add some more docs * rm old docs * wip: comments * nicer docs * cow * fix docs * split bitset * change ot a hash map * throw an error * more comments * comments
The original implementation for opening a vector reader would swallow all IOErrors into None, meaning we might ignore vector data that exists due to arbitrary IO errors. It seems like the original intent was to gracefully skip over vector data when the tantivy index doesn't contain any vector files, even if the schema does. But this should be handled by optionally initializing the the vector reader file handle. Reading the subsequent data should not have to handle the file missing.
…r-error-handling Stricter error handling for vector reader
We were using a panicking version of the datetime converter which would fail on out-of-range datetimes, e.g. "9999-12-31T23:59:59-07:00". Now we fall back to string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.