Make segment manager warning debug#29
Open
Manu Goyal (manugoyal) wants to merge 1 commit into
Open
Conversation
According to some AI exploration, this message starts appearing when we mix compaction and merging work: What’s happening is likely Tantivy background merging. That setting makes the compact WAL writer run Tantivy’s own background merge policy. During compaction we also keep committing WAL batches that delete/re-add rows. Tantivy can start a merge for segments A+B, then a later commit/delete pass updates the in-memory SegmentManager and one of those segments is no longer present when the merge finishes. So end_merge() logs couldn't find segment in SegmentManager. Tantivy’s own error text says this case is “not necessarily a bug”; it’s a stale merge result. So we demote the message to debug to reduce spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to some AI exploration, this message starts appearing when we mix compaction and merging work:
What’s happening is likely Tantivy background merging. That setting makes the compact WAL writer run Tantivy’s own background merge policy. During compaction we also keep committing WAL batches that delete/re-add rows. Tantivy can start a merge for segments A+B, then a later commit/delete pass updates the in-memory SegmentManager and one of those segments is no longer present when the merge finishes. So end_merge() logs couldn't find segment in SegmentManager. Tantivy’s own error text says this case is “not necessarily a bug”; it’s a stale merge result.
So we demote the message to debug to reduce spam.