Conversation
Implement ProfilerEvent.GetEventKey using event_sequence, attach_activity_id and a timestamp/name/session fallback. Add ProfilerService.IsProfilerGeneratedEvent to filter profiler-origin events (client_app_name, batch_text, statement). Introduce EventsPollingIntervalMs constant, add unit/integration tests and Moq test dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and updates across the codebase, focusing on .NET 10 migration, event filtering logic, UI enhancements, and build automation. The most significant changes include updating all projects to target .NET 10, refining how profiler events are filtered and uniquely identified, improving the WinForms UI code for better performance and maintainability, and adding new build tasks for streamlined publishing.
.NET 10 Migration and Versioning:
.csproj) are updated to target .NET 10 (net10.0ornet10.0-windows), ensuring compatibility with the latest framework features and APIs. The WinForms app version is also incremented to 1.1.0. [1] [2] [3] [4]Profiler Event Filtering and Identification:
ProfilerEventmodel'sGetEventKeymethod is improved to generate a more reliable unique key based on event sequence, activity ID, or a fallback combination, enhancing event deduplication.ProfilerServiceis refactored with a newIsProfilerGeneratedEventmethod for more robust and readable filtering of profiler-generated events.WinForms UI Enhancements:
MainPresenter.csinclude using collection initializers (e.g.,[]) for cleaner code, extracting constants, and improving filter logic for better performance.Build and Publishing Automation:
Testing Improvements:
Moqlibrary for more advanced unit testing capabilities. [1] [2]