feat(0.21.0): registry support for Tier-2 monorepo (skillPath) + Phase-3 strategy migration by broomva · Pull Request #53 · broomva/bstack

broomva · 2026-05-25T22:36:21Z

Summary

Phase 6a of the Broomva skills packaging strategy. Adds the registry support the new broomva/skills Tier-2 monorepo needs, and fixes 8 stale strategy entries that pointed at non-existent per-skill repos.

Changes

Schema additive bump (`schemas/companion-skills.v1.json`)

Optional skillPath field added per skill entry. Pattern ^skills/[a-z0-9][a-z0-9-]*/SKILL\\.md$. When present alongside repo, install command becomes npx skills add <repo> --skill <name>. Schema version remains 1 — purely additive, downstream consumers continue to validate.

Registry (`references/companion-skills.yaml`)

8 strategy entries → 9 entries, all rewritten to point at repo: broomva/skills, skillPath: skills/<name>/SKILL.md (was repo: broomva/<name> pointing at 8 repos that never existed as standalones).
2 new entries: handoff + make-spec — the Tier-3 → Tier-2 graduations from broomva/skills PR #2.
Net: 32 → 35 entries (+1 premortem previously unregistered, +2 workflow & lifecycle).

Install commands (`references/skills-roster.md`)

All 9 strategy entries updated from npx skills add broomva/strategy-skills (bundled — still works during deprecation window) to npx skills add broomva/skills --skill <name> (canonical). New "Workflow & Lifecycle (Tier-2 monorepo)" section added.

VERSION + CHANGELOG

0.20.0 → 0.21.0 (additive minor pre-1.0)
Full CHANGELOG entry with migration notes for downstream consumers

Related arc (all merged today)

Repo	PR	Commit	What
`broomva/skills`	#2	`f21515e`	Monorepo structure + handoff + make-spec graduation
`broomva/skills`	#3	`af42d83`	9 strategy sub-skills migrated from bundle
`broomva/strategy-skills`	#1	`34e8d05`	Redirect-stub for 6mo deprecation window
`broomva/bstack`	this PR	—	Registry support for the above

Test plan

Schema JSON validates (jq parse)
YAML parses cleanly
All 9 strategy entries have skillPath matching regex
handoff + make-spec entries have skillPath
No entry has skillPath with non-broomva/skills repo (semantic validity)
CHANGELOG entry includes migration notes
Post-merge: bstack doctor against fixture schemas

Linear ticket

To be created — proposed BRO-NNNN covering the full skills-monorepo arc (workspace PR #87, #88; skills PR #2, #3; strategy-skills PR #1; this PR).

…3 strategy migration Phase 6a of the Broomva skills packaging strategy. Adds the registry support needed for the new broomva/skills monorepo (Tier-2 vendoring) and fixes the stale strategy entries that pointed at per-skill broomva/<name> repos that never existed as standalones. ## Schema additive bump (companion-skills.v1.json) New optional field `skillPath` per skill entry. When a skill lives inside a monorepo (e.g. broomva/skills), `skillPath` is the relative path to its SKILL.md within that repo (pattern: `skills/<name>/SKILL.md`). Combined with `repo`, install becomes `npx skills add <repo> --skill <name>`. The field is purely additive — existing entries that omit `skillPath` continue to work as standalone per-skill installs. Schema version remains 1 (no breaking change). Downstream `bstack doctor` runs on schema_version: 1 fixtures continue to validate. ## companion-skills.yaml entries ### Strategy block (8 entries → 9 entries, all rewritten) Old: each entry pointed at `repo: broomva/<name>` (8 broken targets — those per-skill repos never existed as standalones; the skills always lived bundled in broomva/strategy-skills/.skills/<name>/). New: all 9 entries (including the previously-unregistered `premortem`) point at `repo: broomva/skills, skillPath: skills/<name>/SKILL.md`, the real monorepo location after Phase-3 migration (broomva/skills PR #3 merge af42d83). ### New workflow & lifecycle block (2 entries) `handoff` (category: lifecycle) and `make-spec` (category: design) — the two Tier-3 → Tier-2 graduations from broomva/skills PR #2 (merge f21515e). Both require min_bstack_version: 0.21.0 (the version this release bumps to, which adds skillPath schema support). ### Net entry count: 32 → 35 (+3 net: +1 premortem, +2 handoff/make-spec) ## skills-roster.md install commands All 9 strategy entries' install commands updated from `npx skills add broomva/strategy-skills` (bundled — still works for backward compat) to `npx skills add broomva/skills --skill <name>` (canonical going forward). Added new "Workflow & Lifecycle (Tier-2 monorepo)" section with handoff + make-spec entries (#30 + #31). ## VERSION 0.20.0 → 0.21.0 (additive minor pre-1.0). ## Test plan - [x] Schema JSON validates (jq parse) ✓ - [x] YAML parses cleanly ✓ - [x] All 9 strategy entries have skillPath matching `^skills/[a-z0-9][a-z0-9-]*/SKILL\.md$` regex ✓ - [x] handoff + make-spec entries have skillPath ✓ - [x] No entry has both `skillPath` and a non-`broomva/skills` repo (semantically valid) ✓ - [x] CHANGELOG entry added with migration notes for downstream consumers ✓ - [ ] Post-merge: `bstack doctor` against schema fixtures (no offline runner here) ## Related - broomva/skills PR #2 — monorepo creation + handoff + make-spec (merge f21515e) - broomva/skills PR #3 — strategy migration (merge af42d83) - broomva/strategy-skills PR #1 — redirect stub (merge 34e8d05) - Strategy: broomva/workspace docs/specs/2026-05-25-skills-packaging-strategy.html §8 Phase 3 + Phase 6a

coderabbitai · 2026-05-25T22:36:28Z

Warning

Review limit reached

@broomva, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 55 minutes and 24 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fe7f5590-741a-4006-9883-cabfacf35862

📥 Commits

Reviewing files that changed from the base of the PR and between a251622 and 1d98f5e.

📒 Files selected for processing (5)

CHANGELOG.md
VERSION
references/companion-skills.yaml
references/skills-roster.md
schemas/companion-skills.v1.json

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/registry-strategy-skills-monorepo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

…attern (Phase 6b) (#60) * feat(0.21.7): bstack skills graduate — crystallize Tier-2 migration pattern (Phase 6b) New `bstack skills graduate <name>` subcommand automating the skill-graduation pattern that ran 8 times manually on 2026-05-25/26 (Phases 2-4f). P16 crystallization — rule-of-three exceeded ~8x. ## What it does Automates: clone source + monorepo → copy canonical content (excl. .git, dot-mirror dirs, LICENSE, skills-lock.json) → append README Tier-2 row → commit + push + PR on monorepo → (--stub) redirect-stub PR on source → (--merge) merge → cleanup. Registry update is printed (copy-paste), not auto-applied (needs coordinated version bump review). ## Files - NEW scripts/skill-graduate.sh (~230 lines) — the engine; env-overridable gh/git/tmpdir/dry-run hooks for hermetic testing - NEW tests/skill-graduate.test.sh — 9 offline tests (arg-parse, dry-run, rename detection, stub-gh/git execution with copy+exclude verification, no-SKILL.md error path). All 9 pass. - CHANGED bin/bstack-skills — graduate) dispatch + usage - CHANGED bin/bstack — top-level usage entry - VERSION 0.21.6 → 0.21.7 ## Validation (P11) - 9/9 hermetic tests pass (offline, stub gh/git) - dry-run verified against real skill names (rename detection: omnivoice-skill → omnivoice) - top-level dispatch `bstack skills graduate --help` routes correctly - invalid-name + missing-name + unknown-option all exit 2; no-SKILL.md exits 1 ## Provenance 8 manual instances: broomva/skills PRs #2-#9 + broomva/bstack PRs #53-#59. The next graduation is one command instead of a full manual cycle. * fix(p20-round-1): address cross-review blockers on skill-graduate CLI P20 cross-review (Strata B) returned NEEDS-WORK (7/10) with 2 blockers + 2 nits + a test-coverage gap. All addressed: 1. [BLOCKER] Word-splitting in copy loop — `for item in $(ls -A)` broke on spaced/globbed filenames (reproduced by reviewer; aborts under set -e mid-copy). Replaced with null-delimited `find -print0 | while read -d ''`. 2. [BLOCKER] Header lie — step 3 claimed "Append a row to the monorepo README Tier-2 table" but no such code existed. Removed the false claim; README row is now correctly documented as a printed manual follow-up (alongside the registry entry), since category placement needs judgment. 3. [idempotency] Re-run safety — added a pre-flight `gh pr list --head` check that bails cleanly if an open PR for the branch already exists, instead of failing opaquely inside the push/PR subshell on the 2nd run. 4. [merge masking] `--merge` no longer swallows genuine merge failures — captures the dual-attempt result and WARNs (red CI / conflicts / gate) instead of `|| true` blackholing. 5. [test gap] T8 now inspects the COPIED TREE (asserts references/ + scripts/ present, .claude/ + LICENSE + skills-lock.json absent) via the new BSTACK_GRADUATE_NO_CLEANUP test hook — previously only checked exit code. Added T10: spaced/globbed-filename regression test (the exact gap that let blocker #1 through a green suite). 9 → 10 tests, all pass. Validation: 10/10 hermetic tests pass. T10 fails against the pre-fix loop (confirmed the regression guard is real). * fix(p20-round-2): surface stub-merge failures too (consistency with monorepo path) Residual nit from P20 round-2 re-review (verdict PASS 9/10): the source redirect-stub merge still had `|| true`, asymmetric with the monorepo path's fix. Now warns on genuine merge failure instead of swallowing. Cosmetic — low-stakes (redirect stub, not canonical content) — but closes the asymmetry the reviewer flagged. 10/10 tests still pass.

broomva merged commit 6cbd308 into main May 25, 2026
4 of 5 checks passed

broomva deleted the feat/registry-strategy-skills-monorepo branch May 25, 2026 22:36

broomva mentioned this pull request May 26, 2026

feat(0.21.7): bstack skills graduate — crystallize Tier-2 migration pattern (Phase 6b) #60

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(0.21.0): registry support for Tier-2 monorepo (skillPath) + Phase-3 strategy migration#53

feat(0.21.0): registry support for Tier-2 monorepo (skillPath) + Phase-3 strategy migration#53
broomva merged 1 commit into
mainfrom
feat/registry-strategy-skills-monorepo

broomva commented May 25, 2026

Uh oh!

coderabbitai Bot commented May 25, 2026

Review limit reached

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

broomva commented May 25, 2026

Summary

Changes

Schema additive bump (schemas/companion-skills.v1.json)

Registry (references/companion-skills.yaml)

Install commands (references/skills-roster.md)

VERSION + CHANGELOG

Related arc (all merged today)

Test plan

Linear ticket

Uh oh!

coderabbitai Bot commented May 25, 2026

Review limit reached

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Schema additive bump (`schemas/companion-skills.v1.json`)

Registry (`references/companion-skills.yaml`)

Install commands (`references/skills-roster.md`)