Skip to content

test: cover remote daemon env forwarding #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
honor2030 wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −0
Open

test: cover remote daemon env forwarding #350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions tests/unit/test_admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,28 @@ def fake_browser_use(path, method, body=None):
]


def test_start_remote_daemon_forwards_remote_cdp_env_to_daemon(monkeypatch):
ensure_calls = []
browser = {"id": "browser-123", "cdpUrl": "https://cdp.example", "liveUrl": "https://live.example"}

monkeypatch.setattr(admin, "daemon_alive", lambda name: False)
monkeypatch.setattr(admin, "_browser_use", lambda path, method, body=None: browser)
monkeypatch.setattr(admin, "_cdp_ws_from_url", lambda url: "ws://example.test/devtools/browser/1")
monkeypatch.setattr(admin, "ensure_daemon", lambda **kwargs: ensure_calls.append(kwargs))
monkeypatch.setattr(admin, "_show_live_url", lambda url: None)

assert admin.start_remote_daemon("work", proxyCountryCode="us") == browser
assert ensure_calls == [
{
"name": "work",
"env": {
"BU_CDP_WS": "ws://example.test/devtools/browser/1",
"BU_BROWSER_ID": "browser-123",
},
}
]


# --- restart_daemon: PID-reuse safety ---

def test_restart_daemon_does_not_signal_when_daemon_unreachable(monkeypatch, tmp_path):
Expand Down