Open
Conversation
Member
|
Seems like a good idea until everything is up to date but even then it's good to know the feature parity. |
BridgeAR
approved these changes
May 14, 2019
BridgeAR
reviewed
May 14, 2019
| |-|-| | ||
| | `callbackify` | 12.1.0 | | ||
| | `debuglog` | 0.11.3 | | ||
| | `format` | <8.4.0 | |
Member
There was a problem hiding this comment.
Mentioning the exact version that is reflected seems better than having this notation. There might be more patch releases that could change some small things from the last time this was checked.
Since the Node.js version implemented by this module differs for each API, a table might be helpful to inform users what APIs they can use (and to keep track of what is still to be done).
strictly this commit is missing: nodejs/node@1b9c40c inconsequential really, but we shouldn't lie!
Member
Author
|
(I will confirm the |
ExE-Boss
approved these changes
Feb 3, 2020
ljharb
reviewed
Feb 3, 2020
| | `getSystemErrorName` | missing | | ||
| | `inherits` | 12.1.0 | | ||
| | `inspect` | <6.0.0 | | ||
| | `isDeepStrictEqual` | missing | |
Member
There was a problem hiding this comment.
https://npmjs.com/deep-equal, with { strict: true }?
This was referenced Feb 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the Node.js version implemented by this module differs for each API, a table might be helpful to inform users what APIs they can use (and to keep track of what is still to be done).