Post-PR #129: Version 2.22.0 + Testing Improvements #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement 3 async methods for daily extract file operations: - get_daily_extract_dates() - Get available extract dates - get_daily_extract_files(date) - Get files for a specific date - get_daily_extract_file(date, filename) - Download a specific file Changes: - Add daily_extracts endpoints to capture_api_responses.py - Implement 3 async methods in ofsc/async_client/core.py - Create comprehensive tests in tests/async/test_async_daily_extract.py - Models (DailyExtractFolders, DailyExtractFiles) already existed - Capture API response for get_daily_extract_dates Test Results: - 4 tests created (2 passed, 2 skipped due to no data) - All methods follow established async patterns - File download method returns bytes as expected 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Implement 5 async methods for event subscriptions and webhook management: - create_subscription(subscription) - Create event subscription - get_subscription(subscription_id) - Get subscription details - get_subscriptions() - List all subscriptions - delete_subscription(subscription_id) - Delete subscription - get_events(params) - Get events from subscriptions Changes: - Add Subscription, Event, and request/response models to models.py - Implement 5 async methods in ofsc/async_client/core.py - Create comprehensive tests including full workflow test - Add subscriptions endpoint to capture_api_responses.py - Capture API response for get_subscriptions - Fix parallel testing: Make -n auto opt-in, not default - Update README with parallel testing documentation Models: - Subscription (with string subscriptionId, not int) - SubscriptionListResponse - CreateSubscriptionRequest - Event - EventListResponse Test Results: - 5 tests created (all passing) - Full workflow test: create subscription, move activity, get events - Saved response validation test Breaking Change: - Removed parallel testing as default in pyproject.toml - Users must now explicitly use `-n auto` for parallel execution - This ensures serial tests run correctly without conflicts 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Updated version from 2.21.0 to 2.22.0 to reflect new async implementations. Updated ENDPOINTS.md with current implementation status: - Daily Extract & Files endpoints: sync → both - Events & Subscriptions endpoints: sync → both - Resources endpoints: sync → both (most), new async-only endpoints - Version updated to 2.22.0 - Date updated to 2026-01-02 Changes: - pyproject.toml: version 2.22.0 - docs/ENDPOINTS.md: 86 lines changed (43 insertions, 43 deletions) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains additional improvements and version updates following the merge of PR #129:
Changes
1. Parallel Testing by Default
addoptsinpyproject.tomlto run parallel tests by default2. Version Update
pyproject.tomldocs/ENDPOINTS.mdversion and date3. Endpoints Documentation
sync→both(3 endpoints)sync→both(5 endpoints)sync→both(3 endpoints) + new async-only endpoints (5 endpoints)Related Issues
Continues work from:
Testing
All tests passing:
uv run pytest # Runs in parallel by defaultFiles Changed
pyproject.toml- version 2.22.0, parallel testing defaultREADME.md- improved testing documentationdocs/ENDPOINTS.md- updated endpoint statusesuv.lock- auto-updated🤖 Generated with Claude Code