fix(ebpf): expand syscall probe coverage#30
Merged
Conversation
…eting The BPF program only attached tracepoints for 9 syscalls across file_io, memory, and network, so process/ipc/signal/time categories were always zero regardless of workload — workers forking via clone, futex contention, and signal traffic were invisible. - Add tracepoints for clone/fork/execve/exit/wait4/kill/exit_group, futex/pipe/pipe2, rt_sigaction/rt_sigprocmask/tgkill, nanosleep/clock_gettime/clock_nanosleep, munmap/brk, and accept/sendmsg/recvmsg/bind/accept4 (helps libcurl/TLS network signal). - Introduce a TRACE_SYSCALL macro so adding probes is a one-liner. - Rewrite categorize_syscall with per-arm syscall annotations. Fixes 63..=81 lumping fcntl/flock/fsync/getdents/chdir/uname into ipc, and 198..=203 placing futex and sched_setaffinity into network. - Add 12 unit tests including explicit regressions for both bugs.
2249e95 to
9a74218
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and fix categorizer mis-bucketing
The BPF program only attached tracepoints for 9 syscalls across file_io, memory, and network, so process/ipc/signal/time categories were always zero regardless of workload — workers forking via clone, futex contention, and signal traffic were invisible.