Skip to content

optimize Feat/checkpoint speedup#133

Merged
mengcody merged 2 commits intobttcprotocol:developfrom
sgz13140:feat/checkpoint_speedup
Mar 10, 2026
Merged

optimize Feat/checkpoint speedup#133
mengcody merged 2 commits intobttcprotocol:developfrom
sgz13140:feat/checkpoint_speedup

Conversation

@sgz13140
Copy link

Description

  1. if CalcCheckpointTimeout returns error then return false in checkIfNoAckIsRequired function
  2. don't check CheckpointPollInterval in Validate()
  3. remove unreachable "return" in GetCheckpointParamsWithRetry function

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Checklist

  • I have added at least 1 reviewer to this PR
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@mengcody mengcody self-requested a review March 10, 2026 03:24
@mengcody mengcody merged commit 61fe071 into bttcprotocol:develop Mar 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants