Skip to content

Feature/ps2 139 support for emandate cancelmandate#62

Open
Rhesa-Buckaroo wants to merge 3 commits intomasterfrom
feature/PS2-139_support_for_emandate_cancelmandate
Open

Feature/ps2 139 support for emandate cancelmandate#62
Rhesa-Buckaroo wants to merge 3 commits intomasterfrom
feature/PS2-139_support_for_emandate_cancelmandate

Conversation

@Rhesa-Buckaroo
Copy link
Copy Markdown
Collaborator

No description provided.

RMG and others added 3 commits April 3, 2023 13:54
Support for EMandate CancelMandate
BPP-2849 - Research - Paypal - .NET SDK - PayPal ExtraInfo
Support for EMandate CancelMandate
Copy link
Copy Markdown
Collaborator Author

I found a blocking regression in this PR.

ConfiguredTransaction.EMandate() now returns new EMandateRequestObject() without any configured request attached, while EMandateRequestObject only operates on ConfiguredDataRequest. That means existing transaction-based call chains like .TransactionRequest().SetBasicFields(...).EMandate().CreateMandate(...) will now fail at runtime when the implementation reaches this.ConfiguredDataRequest.BaseDataRequest.

This effectively changes the service from transaction-based to data-request-only, but the transaction entry point is still exposed. I’d recommend either:

  • restoring the transaction-backed constructor/path, or
  • removing the transaction entry point entirely in the same change and documenting it as a breaking API change.

As it stands, this looks like a runtime-breaking regression for existing SDK consumers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants