Major rewrite #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump go to 1.20 - Add go.mod - Parallel download of files being cached - Preserve and send original modification times - Don't cache databases and DB signatures - A bunch of fixes
If the download goroutine exits before closing the Started channel and other goroutines are waiting on that channel, they will deadlock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
You may want to now that I've added some new stuff into pkgproxy. The result is basically a rewrite since most of the original code is gone, as are the tests and CI config. If you want, feel free to merge this, maybe while integrating stuff into your pipeline.
A quick list of improvements:
Thoughts/reviews/tips welcome.